ci(release): attach both x64 and ARM64 installers#31
Merged
Conversation
The publish step picked only the first .exe (and the old *Setup* filter no longer matches the per-arch artifactName), so a release would attach just one architecture. Now uploads all NSIS installers in dist/ and fixes the x64-only release notes wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #30. That PR added the ARM64 build target but was merged before this CI fix landed, so the release workflow still publishes only one installer.
The
release.ymlpublish step picked just the first.exeindist/(and its old*Setup*filter no longer matches the new per-archartifactName), so a tagged release would attach only one architecture -- and the wrong one (arm64 sorts first), with release notes hard-coded to "x64".Changes
.github/workflows/release.ymldist/(both x64 and ARM64)*Setup*filter (artifacts are nowM2_LOG-<version>-<arch>.exe)Why a separate PR
The fix was pushed to the #30 branch after it had already been merged, so it never reached
main. This PR brings it in cleanly off the latestmain.Effect
After merge, pushing a
v*tag builds and attaches bothM2_LOG-<version>-x64.exeandM2_LOG-<version>-arm64.exeto the GitHub Release.